795722 - Firefox not rendering large images correctly since dlbi landed

Status: VERIFIED FIXED

(Core :: Layout, defect)

Description

[IU]

Since dlbi landed, Firefox will not properly display some images.

STR:

1. Set your browser window size to something no larger than 1024 x 768
2. Open bug 486918 attachment 657868 [details]
3. Notice the incomplete rendering.
4. As you refresh a few times, you should notice that the amount of rendering of the image changes.

Comment 1

[Chris Jones [:cjones] inactive; ni?/f?/r? if you need me]

Warning: link in comment 0 is NSFW.

I can't reproduce in linux-x64/basic win7/d3d10, win7/basic, win7/basic/no-d2d.

IU, can you paste the contents of about:support here?  Thanks!

Comment 2

[Chris Jones [:cjones] inactive; ni?/f?/r? if you need me]

Matt reports not being able to reproduce in mac/GL either.

Comment 3

[IU]

(In reply to Chris Jones [:cjones] [:warhammer] from comment #1)
> Warning: link in comment 0 is NSFW.

Yeah I was going to add a warning for that but then thought it OK since it was posted on the other bug

> IU, can you paste the contents of about:support here?  Thanks!

My copy-paste is not lining things up and ends up a jumbled mess.

Nonetheless, after some more testing, I have found out that it happens only if HW acceleration is disabled (i.e. layers.acceleration.disabled set to false)

Comment 4

[Chris Jones [:cjones] inactive; ni?/f?/r? if you need me]

Thanks.  I wasn't able to reproduce with that pref set to false (comment 1).

Comment 5

[IU]

Never mind.  It's still happening. :-( I'll have to try and debug later.

Maybe it's an XP-only bug

Comment 6

[Maxime]

Attachment: Image display glitch

It happens to me when adding image nodes with a fixed css position dynamically. See the attachment.

Also happens on clean profiles, but works fine in Safe Mode.

Comment 7

[Chris Jones [:cjones] inactive; ni?/f?/r? if you need me]

Thanks for the test!

I can reproduce this with win7/d3d10, but not linux-x64/basic.

Matt, does the patch for bug 795694 fix this?

Comment 8

[Matt Woodrow (:mattwoodrow)]

Attachment: Fix

Not entirely sure what's actually happening here, but it appears that call GetFrame() from within FrameUpdated() isn't doing what I'd expect.

Just deleting the ImageContainer so that we call GetFrame() next time we need it works...

Comment 9

[Matt Woodrow (:mattwoodrow)]

https://hg.mozilla.org/mozilla-central/rev/b0fc903a0749

Comment 10

[IU]

Working fine with today's nightly.  Thanks.

http://hg.mozilla.org/mozilla-central/rev/85dd8e346102

Comment 11

[IU]

I guess the tracking flag got reset when I posted.  That was not intentional.

Comment 12

[Paul Silaghi, QA [:pauly]]

Reproducible on nightly 2012-09-30 using the testcase in comment 6.
Verified fixed FF 18b4 Win XP.